render JSON object keys correctly - #632
Merged
Merged
Conversation
bgentry
force-pushed
the
bg/fix-json-view-keys
branch
from
August 1, 2026 00:48
2cabaaf to
cb2b792
Compare
brandur
approved these changes
Aug 1, 2026
bgentry
marked this pull request as ready for review
August 1, 2026 03:21
`JSONView` uses property-key truthiness to distinguish root values from object properties, which drops empty-string keys from rendered output. It also interpolates keys between quotes without escaping their contents. Check the existing null sentinel explicitly and render property keys with `JSON.stringify`. This keeps empty and escaped keys visible as valid JSON strings in the structured viewer. Cover both cases in the component tests.
bgentry
force-pushed
the
bg/fix-json-view-keys
branch
from
August 1, 2026 15:09
cb2b792 to
a7ea4d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JSONViewcurrently treats property-key presence as a truthy check, so an empty-string key is rendered as though its value were at the root. Keys are also interpolated between quote characters without JSON escaping, which makes quotes and control characters display incorrectly.This checks the existing null sentinel explicitly and renders keys with
JSON.stringify, keeping empty and escaped property names visible as valid JSON strings.Stacked on #594; the reviewable change is the single commit above that branch.